"Add Shipping Details" CTA button is not displayed in the workspace chat when self-assigning an Expensify card. #54917

[mallenexpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation (hyperlinked to channel name): convert

Action Performed:

1. Assign a card to yourself.
2. Observe the message in the workspace chat requesting an address update.
3. Notice that the message does not provide a direct link to the address section.

Expected Result:

The message in the workspace chat should include a clear link or instructions on how to navigate to the address section of the profile and Add shipping Details button

Actual Result:

The message only mentions that an address is required but does not provide guidance on where or how to add it and Add shipping details button not displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

[mallenexpensify]

Posts from others in deleted issue, in order

From @DylanDylann

@vit @JoeKaufman I investigated this issue. This is my assumption:

In this issue, the card isn't created successfully for some reason but the BE still returns a report action with reportName is CARDMISSINGADDRESS

Let's see the condition to display the message: issued @[email protected] an Expensify Card! The card will be shipped once shipping details are added.

App/src/libs/ReportActionsUtils.ts

Line 1838 in 4d0472f

const shouldShowAddMissingDetailsMessage = !isAssigneeCurrentUser || (reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.CARD_MISSING_ADDRESS && missingDetails);

Let's see the condition to display Add shipping detail button

App/src/components/ReportActionItem/IssueCardMessage.tsx

Line 55 in 4d0472f

const shouldShowAddMissingDetailsButton = !isEmptyObject(card) && action?.actionName === CONST.REPORT.ACTIONS.TYPE.CARD_MISSING_ADDRESS && missingDetails && isAssigneeCurrentUser;

We have an additional condition compared to the condition to display the message. It is the check isEmptyObject(card)

And in this case, the card isn't created successfully. So the CARDMISSINGADDRESS message still be displayed but the card button isn't displayed.

My suggestion is to make the condition display the message and the button are consistent.

From @mountiny

@DylanDylann hmm if the card was not created successfully, we would not create the report action either, the command would throw

From @DylanDylann

@mountiny This is only my assumption. Currently, I can't reproduce this problem, @puneetlath could you help to reproduce this issue again? If you still reproduce it, please export your Onyx data then I can help to investigate and finD the correct RCA

cc @puneetlath

From @mountiny

This was from a real customer so we cannot easily get the data unfortunately. Its not clear right now why this happened.

It might be good to write failing unit test that would lead to show this message but no button

From @DylanDylann

It might be good to write failing unit test that would lead to show this message but no button

@mountiny Agreed with you. Do you want to export this to contributors?

[melvin-bot]

Current assignee @maddylewis is eligible for the Bug assigner, not assigning anyone new.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989