[HOLD for payment 2025-01-17] Hybrid - Android - Onboarding - "Travel and expense, at the speed of chat" modal appears after every login

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.82-4
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #54972
Issue reported by: Applause Internal Team
Device used: Samsung S23FE/ Android 14
App Component: Other

Action Performed:

Setup:
It can be run on the Web (https://staging.expensify.com)

1. Sign in to a new account on OldDot
2. Create a workspace
3. Create a report with expenses and submit it
4. Run this script in the browser console:
   NVP.set('tryNewDot', {classicRedirect: {dismissed: true, completedHybridAppOnboarding: false}, nudgeMigration: {timestamp: '2024-01-07'}});

Steps:

1. Open the Expensify app
2. Sign in to the same account registered in the setup
3. Switch to NewDot
4. Confirm that the "Travel and expense, at the speed of chat" modal is displayed
5. Tap on "Let's go!"
6. Log out and log in again

Expected Result:

The "Travel and expense, at the speed of chat" modal only appears after the first login for migrated accounts.

Actual Result:

The "Travel and expense, at the speed of chat" modal appears after every login in migrated accounts.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6709600_1736393099906.Onboarding_-_Modal_always_appears.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[aldo-expensify]

Seems like this is getting fixed by #55005, so this doesn't look like a DeployBlocker

[blimpich]

Just merged the PR, will wait to see that CP-ed and then retest this

[blimpich]

Asked for retest here: https://expensify.slack.com/archives/C9YU7BX5M/p1736454070227579

[kavimuru]

Reproducible in 9.0.82-5

Onboarding.-.Modal.always.appears.-.Retest_2.mp4

[thienlnam]

Should be resolved in 9.0.82-6

[blimpich]

@thienlnam tester has it still not working, even when given an apk for the latest version: https://expensify.slack.com/archives/C9YU7BX5M/p1736463627682619?thread_ts=1736454070.227579&cid=C9YU7BX5M

Should we keep the deploy blocker label?

[thienlnam]

Oh hmm @rayane-djouah @allroundexperts @puneetlath, looks like #55005 didn't fix this

[melvin-bot]

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[blimpich]

Conversation is ongoing in slack here: https://expensify.slack.com/archives/C01GTK53T8Q/p1736464127120649?thread_ts=1736444631.474489&cid=C01GTK53T8Q

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: "Travel and expense" modal not showing for migrated users #55005
• Fix: Hybrid - Android - Onboarding - "Travel and expense, at the speed of chat" modal appears after every login #55039

If no regressions arise, payment will be issued on 2025-01-17. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @rayane-djouah requires payment (Needs manual offer from BZ)

[melvin-bot]

@allroundexperts / @rayane-djouah @muttmuure @allroundexperts / @rayane-djouah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]