[$250] Add unit tests for approval chain / next approver logic to handle correct optimistic next approver

[Beamanator]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Goal of issue:

We agreed here and here that it would be great to write unit tests for this project, but we didn't want to hold the project on writing tests b/c it was a pretty complex change that had already gone on for a while.

So in this issue, we will write some tests!! Specifically:

1. We should create a unit test for getSubmitToAccountID to cover the correct submitsTo.
2. We should create a unit test for getApprovalChain to cover the correct list order approval chain.

Before the PR is created, let's also check if there's other utils functions that should have unit tests written for them, specifically related to

1. Advanced & basic & no approvals
2. Rule approvers (when some exist vs none exist)
3. Control vs Collect policies

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021877327432534526910
• Upwork Job ID: 1877327432534526910
• Last Price Increase: 2025-01-09
• Automatic offers:
• nkdengineer | Contributor | 105623817

Issue Owner

Current Issue Owner: @eh2077

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021877327432534526910

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[Beamanator]

@nkdengineer is planning to work on this one

[nkdengineer]

@Beamanator I'm here.

[Beamanator]

yooo

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖