Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Chat - The mention suggestion list is slow to respond #54991

Open
2 of 8 tasks
IuliiaHerets opened this issue Jan 9, 2025 · 14 comments
Open
2 of 8 tasks

iOS - Chat - The mention suggestion list is slow to respond #54991

IuliiaHerets opened this issue Jan 9, 2025 · 14 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.82-3
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, repro on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5428982&group_by=cases:section_id&group_id=292106&group_order=asc
Issue reported by: Applause Internal Team
Device used: iPhone 13
App Component: Chat Report View

Action Performed:

  1. Open the iOS Hybrid app
  2. Navigate to the 1:1 DM or room chat
  3. Send a message with a user mention

Expected Result:

The mention suggestion list is displayed after typing @

Actual Result:

The mention suggestion list is slow to respond

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6709437_1736370013886.ScreenRecording_01-08-2025_15-44-52_1.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Jan 9, 2025
Copy link

melvin-bot bot commented Jan 9, 2025

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 9, 2025

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jan 9, 2025

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label Jan 9, 2025
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lakchote
Copy link
Contributor

lakchote commented Jan 9, 2025

Could it be #54805?

@ikevin127
Copy link
Contributor

I remember experiencing this issue myself specifically on iOS: Native when I was working on the mentioned PR, before applying the filtering logic and, noting that I was on a new account, meaning small suggestion list. I checked by replacing the added filtering here:

// on staging server, in specific cases (see issue) BE returns duplicated personalDetails
// entries with the same `login` which we need to filter out
return array.findIndex((arrayDetail) => arrayDetail?.login === detail?.login) === index;

with return true; as it was before the PR and the issue is still reproducible. I'm suspecting something related to reanimated given the recent react-native version upgrade, but nothing solid yet.

@lakchote
Copy link
Contributor

lakchote commented Jan 9, 2025

Thanks for your quick answer @ikevin127!

@mountiny
Copy link
Contributor

mountiny commented Jan 9, 2025

I cannot reproduce this and i should have many personal details locally

trim.E7E2CBF1-E520-4E26-AC60-69EC31039A5A.MOV

@mountiny
Copy link
Contributor

mountiny commented Jan 9, 2025

As such i would recommend demoting this, we have not seen a report from internal user about this so maybe its specific to huge testing domain.

We should still investigate and find where this regression came from

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jan 9, 2025
@lakchote
Copy link
Contributor

lakchote commented Jan 9, 2025

Asked if Margelo team is able to take on this issue here.

@hannojg
Copy link
Contributor

hannojg commented Jan 9, 2025

yes, team Margelo will look into this. Someone from our team will soon comment for working on this, in the meantime feel free to assign this to me so it doesn't get lost!

A question to @IuliiaHerets : is this happening on all applause accounts? If not, can you please share the specific account email address that you can reproduce this with? (We will try to use the same account for easier reproduction)

@lakchote
Copy link
Contributor

lakchote commented Jan 9, 2025

Assigning to @hannojg in the meantime

@danstepanov
Copy link

Hey I am Dan from Margelo and would like to work on this issue 👋

Copy link

melvin-bot bot commented Jan 9, 2025

📣 @danstepanov! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

7 participants