Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove months and years from default units #177

Closed
EvanHahn opened this issue Jun 11, 2020 · 1 comment
Closed

Remove months and years from default units #177

EvanHahn opened this issue Jun 11, 2020 · 1 comment
Labels
good starter task
Milestone
v4.0.0

Comments

@EvanHahn
Copy link
Owner

EvanHahn commented Jun 11, 2020 •
edited
Loading

Currently, the units option defaults to including months and years.

This line:

HumanizeDuration.js/humanize-duration.js

Line 1003 in 6029e98

units: ["y", "mo", "w", "d", "h", "m", "s"],

Should be changed to ["w", "d", "h", "m", "s"].

This pull request should be made against the v4.0.0 branch, which you can see in #176.
@EvanHahn EvanHahn added this to the v4.0.0 milestone Jun 11, 2020
@EvanHahn EvanHahn mentioned this issue Jun 11, 2020
Closed
12 tasks
@morrme morrme mentioned this issue Jun 30, 2020
Merged
EvanHahn pushed a commit that referenced this issue Jul 2, 2020
@morrme
Removed month and year from default units
1389b4a 
See [#185](#185).

Closes [#177](#177).
@EvanHahn
Copy link
Owner Author

EvanHahn commented Jul 2, 2020

Closed in 1389b4a.

@EvanHahn EvanHahn closed this as completed Jul 2, 2020
EvanHahn pushed a commit that referenced this issue Jul 2, 2020
@morrme @EvanHahn
Removed month and year from default units
7f33569 
See [#185](#185).

Closes [#177](#177).
EvanHahn pushed a commit that referenced this issue Jul 16, 2020
@morrme @EvanHahn
Removed month and year from default units
e8c6c67 
See [#185](#185).

Closes [#177](#177).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good starter task
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
1 participant
@EvanHahn