Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gr language code #174

Closed
EvanHahn opened this issue Jun 3, 2020 · 1 comment · Fixed by #175
Closed

Remove gr language code #174

EvanHahn opened this issue Jun 3, 2020 · 1 comment · Fixed by #175
Assignees
@EvanHahn
Milestone
v4.0.0

Comments

@EvanHahn
Copy link
Owner

EvanHahn commented Jun 3, 2020

el is the right language code for Greek. Because of a bug, gr was introduced and maintained for backwards compatibility.

In the next major version of this library, we should remove gr.
@EvanHahn EvanHahn added this to the v4.0.0 milestone Jun 3, 2020
@EvanHahn EvanHahn self-assigned this Jun 3, 2020
EvanHahn added a commit that referenced this issue Jun 3, 2020
@EvanHahn
Remove gr language code
9510f1e 
Closes [#174][0].

[0]: #174
@EvanHahn EvanHahn mentioned this issue Jun 3, 2020
Merged
EvanHahn added a commit that referenced this issue Jun 3, 2020
@EvanHahn
Remove gr language code
f57dd8c 
Closes [#174][0].

[0]: #174
@EvanHahn EvanHahn mentioned this issue Jun 3, 2020
Closed
12 tasks
EvanHahn added a commit that referenced this issue Jun 4, 2020
@EvanHahn
Remove gr language code
eaf8527 
Closes [#174][0].

[0]: #174
@EvanHahn
Copy link
Owner Author

Closing this as it's been merged into the 4.0 branch (see #176 for more).

EvanHahn added a commit that referenced this issue Jun 11, 2020
@EvanHahn
Remove gr language code
e277278 
Closes [#174][0].

[0]: #174
EvanHahn added a commit that referenced this issue Jun 11, 2020
@EvanHahn
Remove gr language code
d415828 
Closes [#174][0].

[0]: #174
EvanHahn added a commit that referenced this issue Jun 24, 2020
@EvanHahn
Remove gr language code
c0ef06d 
Closes [#174][0].

[0]: #174
EvanHahn added a commit that referenced this issue Jul 2, 2020
@EvanHahn
Remove gr language code
143adc0 
Closes [#174][0].

[0]: #174
EvanHahn added a commit that referenced this issue Jul 16, 2020
@EvanHahn
Remove gr language code
d5fefe9 
Closes [#174][0].

[0]: #174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EvanHahn EvanHahn

Labels
None yet
Projects
None yet
Milestone
v4.0.0
1 participant
@EvanHahn