Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[List Item]: add icon-end/start props #9175

Closed
6 of 10 tasks
ashetland opened this issue Apr 23, 2024 · 7 comments
Closed
6 of 10 tasks

[List Item]: add icon-end/start props #9175

ashetland opened this issue Apr 23, 2024 · 7 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. c-list Issues that pertain to the calcite-list component Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality p4 - not time sensitive User set priority status of p4 - not time sensitive ready for dev Issues ready for development implementation.

Comments

@ashetland
Copy link
Contributor

ashetland commented Apr 23, 2024

Check existing issues

Description

List Item should match other similar components in this regard and include properties for icon-end and icon-start. This would improve the OOTB experience when adding icons to list items vs the current workflow of relying the content slots.

Acceptance Criteria

  • icon-end/start props added
  • default color should be text.3
  • when the item is selected, the color should match the heading (text.1)
  • icons should be scale="m" (24px) on scale="l" List Items

image

Relevant Info

No response

Which Component

List Item

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)

@ashetland ashetland added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 23, 2024
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Apr 23, 2024
@ashetland
Copy link
Contributor Author

cc @driskull

@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Apr 23, 2024
@macandcheese macandcheese added the c-list Issues that pertain to the calcite-list component label May 1, 2024
@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 5 A few days of work, definitely requires updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Aug 15, 2024
@geospatialem geospatialem added this to the 2024-11-19 - Nov Release milestone Aug 15, 2024
@geospatialem
Copy link
Member

Listed as a p - high to ensure all related list visual and breaking changes are in alignment for the November breaking change release. While the above is not a breaking or visual change it relates to other breaking changes such as #7100. cc @ashetland

@github-actions github-actions bot added the p4 - not time sensitive User set priority status of p4 - not time sensitive label Oct 24, 2024
@ashetland ashetland removed the impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive label Oct 24, 2024
@aPreciado88 aPreciado88 self-assigned this Oct 28, 2024
@aPreciado88 aPreciado88 added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Oct 28, 2024
@ashetland
Copy link
Contributor Author

Due to the refactor required by #7100, it might make sense to wait to add these until after 7100 is complete.

@ashetland ashetland added design Issues that need design consultation prior to development. ready for dev Issues ready for development implementation. labels Nov 18, 2024
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Nov 18, 2024
Copy link
Contributor

cc @geospatialem, @brittneytewks

@ashetland ashetland removed the 0 - new New issues that need assignment. label Nov 18, 2024
@ashetland ashetland added the 1 - assigned Issues that are assigned to a sprint and a team member. label Nov 18, 2024
@ashetland ashetland removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Nov 18, 2024
@aPreciado88 aPreciado88 added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Dec 3, 2024
aPreciado88 added a commit that referenced this issue Dec 10, 2024
**Related Issue:**
[#9175](#9175)

## Summary

- Add `iconStart`, `iconEnd` and `iconFlipRtl` props.
- Update default icon color to `--calcite-color-text-3`.
- Update icon color to `--calcite-color-text-1` when item is selected.
- Update `list.html` and `list.stories.ts` to use `icon-start` and
`icon-end`.
@aPreciado88 aPreciado88 added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Dec 10, 2024
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned aPreciado88 Dec 10, 2024
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 10, 2024
@geospatialem
Copy link
Member

Verified on Storybook with the icon-start and icon-end attributes (iconStart and iconEnd props) and selection states. 👍🏻

@aPreciado88
Copy link
Contributor

Created follow up issue to split storybook screenshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. c-list Issues that pertain to the calcite-list component Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality p4 - not time sensitive User set priority status of p4 - not time sensitive ready for dev Issues ready for development implementation.
Projects
None yet
Development

No branches or pull requests

5 participants