Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[List/List Item] Refactor so parent List inherits displayMode value #10949

Closed
1 of 5 tasks
geospatialem opened this issue Dec 3, 2024 · 2 comments
Closed
1 of 5 tasks

[List/List Item] Refactor so parent List inherits displayMode value #10949

geospatialem opened this issue Dec 3, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Milestone
2024-12-17 - Dec ...

Comments

@geospatialem
Copy link
Member

Description

Currently the list and list-item components can both be set to differing displayMode values of "flat" or "nested". Instead, we should refactor the components, similar to the scale property across the design system and instead have the parent element provide its descendants with the same value for consistency.

cc @driskull @jcfranco

Proposed Advantages

  • Similar to scale use across the design system
  • Ease of implementation for designers and developers

Which Component

  • list
  • list-item

Relevant Info

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components
@geospatialem geospatialem added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 3, 2024
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Dec 3, 2024
@geospatialem geospatialem changed the title [List/List Item] Refactor so parent List inherits [List/List Item] Refactor so parent List inherits displayMode value Dec 3, 2024
driskull added a commit that referenced this issue Dec 3, 2024
@driskull
refactor(list-item): set displayMode on slotted list. #10949
19fab74
@driskull driskull mentioned this issue Dec 3, 2024
Merged
@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 6, 2024
driskull added a commit that referenced this issue Dec 9, 2024
@driskull
refactor(list-item): set displayMode on slotted list (#10965)
1a3cd67 
**Related Issue:** #10949

## Summary

- set displayMode on slotted list
- cleanup 🧹 
- e2e test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Dec 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Installed and assigned for verification.

@github-actions github-actions bot assigned DitwanP and unassigned driskull Dec 9, 2024
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 10, 2024
@geospatialem
Copy link
Member Author

Verified in 3.0.0-next.53 with https://codepen.io/geospatialem/pen/YPKWgqQ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

No branches or pull requests
3 participants
@driskull @geospatialem @DitwanP