Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Move all CRC code to transport layers #445

Open
2 tasks done
amgross opened this issue Jan 2, 2025 · 0 comments
Open
2 tasks done

[FEATURE] Move all CRC code to transport layers #445

amgross opened this issue Jan 2, 2025 · 0 comments
Labels
enhancement

Comments

@amgross
Copy link
Contributor

amgross commented Jan 2, 2025 •
edited
Loading

Is your feature request related to a problem? Please describe

Currently, in server/client setup there is member and initialization of CRC, but it used just in framed transport.

Even if someone has transport that don't need CRC, still it holds CRC object in client layer.

Describe the solution you'd like

Initialize and hold CRC in transports that used it, for example in framed transport.

Describe alternatives you've considered

Steps you didn't forgot to do

  • I checked if there is no related issue opened/closed.
  • I checked that there doesn't exist opened PR which is solving this issue.

Additional context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amgross