Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for opt-in panic hooking #78

Open
Jake-Shadle opened this issue Jun 15, 2023 · 2 comments
Open

Add support for opt-in panic hooking #78

Jake-Shadle opened this issue Jun 15, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@Jake-Shadle
Copy link
Member

It'd be nice to allow users to opt-in to panic handling that could also be reported with a minidump the same as crashes.

@Jake-Shadle Jake-Shadle added the enhancement New feature or request label Jun 15, 2023
@ReactorScram
Copy link

Yeah right now I'm seeing that if I panic at any point after setting up crash handling, it leaks the server process? Maybe I've set something up wrong?

@ReactorScram
Copy link

ReactorScram commented Jan 12, 2024

nvm just found the docs for stale connections https://docs.rs/minidumper/latest/minidumper/struct.Server.html#method.run

Edit: on_client_disconnected seems to work, I told it to exit if there's 0 clients left connected. https://docs.rs/minidumper/latest/minidumper/trait.ServerHandler.html#method.on_client_disconnected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants