-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add profile resolution to global configuration (kdeglobals) #15
Comments
What exactly do you mean with "profile"? Ideally we would treat everything with a simple |
The keys are currently in the form The profile can be either set programmatically, by parameter I am not using As kde globals have a special meaning in KDE I wanted to ask, if we should make it possible to use different profiles for the applications and the global settings. |
Good, so this is something similar to what the profile plugin does: https://www.libelektra.org/plugins/profile Please already start documenting this, so that we know which features are intended and how they work.
You can and should also call ksLookup even if you iterate over all keys. I just see that this is not explained in doc/tutorials/application-integration.md but it already says: "To make this work within your application make sure to always call
Yes, I agree that it makes sense. Just because someone switches the profile of an application does not mean someone wants to switch to different kde globals. |
I added the documentation, should I create a separate PR for this branch?
I am now using ksLookup on the keys. |
Yes, please separately. We should merge #13 or #15 as fast as possible, as it is now quite chaotic what is reviewed and what is from you.
Thank you! Did you use cascading lookup (without namespace)? Did this change anything in the performance? |
Yes, I am using cascading namespaces. As far as I can tell, there is no noticeable change in performance. edit: added space |
Should the profile for the kde globals be the same profile as for the other configuration? Or should we use a different one, maybe with a fallback option (if no globals profile is set, check if another profile is set, if so use this, else use the default profile)
@markus2330 what are your thoughts on this?
The text was updated successfully, but these errors were encountered: