Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[💡 FEATURE REQUEST] #87

Open
dandalgatov opened this issue Sep 7, 2022 · 1 comment
Open

[💡 FEATURE REQUEST] #87

dandalgatov opened this issue Sep 7, 2022 · 1 comment
Assignees
Labels
💡 enhancement New feature or request 🆘 help wanted Extra attention is needed 🆕 new feature

Comments

@dandalgatov
Copy link

Hello, I wanted to make something similar to your app but now that I have discovered it I might just end up using this instead. Great job by the way. My suggestion is to restructure UI a little bit. The current UI is not clear at a glance. Here is a mock-up of how I envisioned it, and feel free to use it if you decide to revisit it in the future.
Screen Shot 2022-09-06 at 8 57 06 PM

We have station names separating blocks of train times so it's easier to look at the trains for the station you are interested in.
Stations can be ordered by walk time from nearest to furthest.
Stations can have 2 directions except when it's

  • Starting station
  • There is no service in one direction for maintenance
  • User doesn't care about one of the directions and wants it off.

There is a version of both scenarios. Also, default direction names aren't intuitive. It's not as important for me to know the end station as much as it is to know which borough the train is running to. Having the ability to rename directions would be huge. Alternatively, the borough can be programmatically determined. As far as I can tell there is no instance where you can go to 3 separate boroughs from one station without passing through one of the boroughs. Meaning if I have a train that starts in QN and goes to MNHT, and ends up in BK eventually, for me from the point of view of Queens train station, the direction will be MNHT. It's less relevant that I will end up in Brooklyn which is kinda how current default destinations work.

@Elaniobro
Copy link
Owner

@dandalgatov re train direction. This info is pulled directly from the API. I will not be coding in logic to determine which borough its headed towards.

In your usecase:

Meaning if I have a train that starts in QN and goes to MNHT, and ends up in BK eventually, for me from the point of view of Queens train station, the direction will be MNHT. It's less relevant that I will end up in Brooklyn which is kinda how current default destinations work.

The A Train originating in QN is headed downtown into BK. Even if I were to code the logic, I would not program it to say A Train from QN -> MNHT.

I do like your new UI/Layout ideas. I have been incredibly busy an unable to give much <3 to this module. I also no longer have a mirror so there is that.

FWIW, this repo specifically uses ES5; as ES6 is not supported on a pi0w, which is what I was using. Feel free to submit a PR with the UI if you have the time and want to take a stab at it.

Cheers!

@Elaniobro Elaniobro added 💡 enhancement New feature or request 🆘 help wanted Extra attention is needed 🆕 new feature labels Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 enhancement New feature or request 🆘 help wanted Extra attention is needed 🆕 new feature
Projects
None yet
Development

No branches or pull requests

2 participants