Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colcon-poetry-ros v0.9.0 breaks the colcon build process #120

Open
glpuga opened this issue Jan 2, 2025 · 1 comment
Open

colcon-poetry-ros v0.9.0 breaks the colcon build process #120

glpuga opened this issue Jan 2, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@glpuga
Copy link
Collaborator

glpuga commented Jan 2, 2025

Bug description

Building lambkin from scratch today in another machine I ended up with an image where colcon build for #116 does not work.

image

The problem seems to be:

RUN pip install colcon-common-extensions poetry colcon-poetry-ros
## NOTE(hidmic): remove colcon-poetry-ros weird script relocation
RUN sed -i '111,131d' $(python3 -c "import colcon_poetry_ros.task.poetry.build as m; print(m.__file__)")

A machine where the same image works installs colcon-poetry-ros 0.8.0, while one where it does not work installs 0.9.0.

Downgrading to 0.8.0 fixes the issue.

RUN pip install colcon-common-extensions poetry colcon-poetry-ros==0.8.0

Platform (please complete the following information):

How to reproduce

  1. Follow https://github.com/Ekumen-OS/lambkin/blob/glpuga/beam_skipping_evaluation/src/benchmarks/beam_skipping_evaluation/README.md

Expected behavior

I expect

BUILD_DOCUMENTATION=false BUILD_TESTING=false colcon build --packages-up-to beam_skipping_evaluation --symlink-install

succeds.

Actual behavior

It fails complaining about a missing "]" within build.py in colcon-poetry-ros.

Additional context

Any other information you think could be meaningful to this issue.

@glpuga glpuga added the bug Something isn't working label Jan 2, 2025
@glpuga
Copy link
Collaborator Author

glpuga commented Jan 2, 2025

@marcoshuck for awareness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant