[FEATURE] Switch from Create React App to Vite?

[dan-mba]

Description

I noticed this project is using Create React App and was wondering if you would be interested in switching to Vite.

Vite has faster builds and is more configurable.

Screenshots

No response

Additional information

No response

[amandamartin-dev]

Hey @dan-mba sorry for the delay responding to this. I think this would be best opened up as a discussion. I've read about Vite but haven't actually used it yet. Would you like to start the convo in the discussions area and other folks can weigh in as well?

[dan-mba]

Hey @dan-mba sorry for the delay responding to this. I think this would be best opened up as a discussion. I've read about Vite but haven't actually used it yet. Would you like to start the convo in the discussions area and other folks can weigh in as well?

Can you convert this issue to a discussion?

It requires write access to the repo.
Here are the instructions

[amandamartin-dev]

Thanks! Completely missed that.

So I've read a bit about Vite and see how it's considered a better option for production in many cases but curious if it is necessary for a smaller project like this that has a very specific use case. Curious what you are thinking is the benefit here? Also curious what others are thinking as well.

[dan-mba]

The main benefit of moving to Vite is improved speed in development & production build.
An explanation of how Vite does this is on [their website(https://vitejs.dev/guide/why.html).

Vite is also updated regularly, so it reduces the need for package.json overrides or eject workarounds.

Vite is used by some newer frameworks like Astro & SvelteKit.
I personally use it on all of my React projects that don't use a framework like Next or Gatsby.

[Cahllagerfeld]

I'd also be in favor of migrating for the given reasons!

[amandamartin-dev]

Thank you so much for weighing in! I agree with Dan too just haven't used Vite yet so appreciate your thoughts as well.

[dan-mba]

Ok, I will work on a PR for this migration.

[Cahllagerfeld]

I was hacking around with it, see on the new branch. I didn't open the PR just yet though, because it's not properly tested (yet)

[amandamartin-dev]

You are so fast! I will take a look later and play around. @dan-mba would love your thoughts on the branch too as you have much experience with Vite

[dan-mba]

A couple of thoughts:

You can remove all of the @testing-library dependencies as you aren't using them (CRA added them by default)
I would recommend installing eslint & eslint-plugin-react (linting was setup by default with CRA)
Migrate eslint config out of package.json npx eslint --init (The package.json setup doesn't work well with vscode).
Try removing the overrides section of package.json (from what I can tell, it is not a sub-dependency of anything else)

If you need any help, at me on GitHub or mention me on EddieHub discord ( my id is dan-mba there too)