Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Actor SPS includes learning elements #130

Open
thomashirtz opened this issue Nov 15, 2024 · 2 comments
Open

[BUG] Actor SPS includes learning elements #130

thomashirtz opened this issue Nov 15, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@thomashirtz
Copy link

Describe the bug

When logging the acting, the SPS is around the learn function, therefore the acting sps is actually logging the acting time.

See #129 (comment)
@thomashirtz thomashirtz added the bug Something isn't working label Nov 15, 2024
@EdanToledo
Copy link
Owner

I think the only thing to do is figure out if its even possible to have timings inside a jitted function. If its not possible then we are unfortunately bound by jax. I'll look into this soon.

@thomashirtz
Copy link
Author

Yeah that is what I was thinking
I guess that if we have the evaluation time and the training time it is quite good already.
Although if we can extract the actor time, that would be nice to also be able to extract the env step SPS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomashirtz @EdanToledo