Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/cfish on patched paper server #525

Open
sofianedjerbi opened this issue May 12, 2023 · 2 comments
Open

/cfish on patched paper server #525

sofianedjerbi opened this issue May 12, 2023 · 2 comments
Labels
question This issue is a question

Comments

@sofianedjerbi
Copy link

Hello,

I wanted to "patch" paper to be able to run ccrackrng cenchant and cfish.
Removing the following patch don't seem to work on cfish (but ccrackrng works fine): https://github.com/PaperMC/Paper/blob/df8d28a450fe391b9f0c2dc4a64543cf9b84266f/patches/server/0070-Use-a-Shared-Random-for-Entities.patch
What other aspect of the FishingHookEntity does clientcommands rely on ? So I can "patch" paper to support it again 🤔

@Earthcomputer
Copy link
Owner

Earthcomputer commented May 12, 2023

It's surprising to me that cfish doesn't work for you after removing that patch. clientcommands relies on the exact movement of the fishing hook, all its random calls (except bobbing on the surface because the hook isn't allowed to go above the surface), the time at which the fish bites and the loot table logic.

@sofianedjerbi
Copy link
Author

sofianedjerbi commented May 12, 2023

Okay, I'll look into it. (No output, it just fail)
It works fine on CB/spigot

@Earthcomputer Earthcomputer added the question This issue is a question label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question This issue is a question
Projects
None yet
Development

No branches or pull requests

2 participants