Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When provider object in STAC has roles entry it no longer is rendered if selected in featured section #1496

Closed
santilland opened this issue Jan 27, 2025 · 3 comments · Fixed by #1513
Labels
bug Something isn't working stacinfo

Comments

@santilland
Copy link
Member

For example following providers are not shown in the featured section:

"providers": [
    {
      "name": "Mercator Oc\u00e9an International",
      "description": "Mercator Ocean describes, analyses and forecasts the state of the ocean by developing the \"Mercator System\" for ocean analysis and forecasting and maintaining it in an operational condition.",
      "roles": [
        "producer"
      ],
      "url": "https://www.mercator-ocean.eu/"
    },
    {
      "name": "E.U. Copernicus Marine Service Information (CMEMS)",
      "description": "The Copernicus Marine Service (or Copernicus Marine Environment Monitoring Service) is the marine component of the Copernicus Programme of the European Union.",
      "roles": [
        "host"
      ],
      "url": "https://data.marine.copernicus.eu/"
    }
  ],

Image

@santilland santilland added bug Something isn't working stacinfo labels Jan 27, 2025
@silvester-pari
Copy link
Collaborator

The issue seems to be that we filter out all links which do not include metadata:

if (itemValue.roles) pass = itemValue.roles.includes("metadata");

This probably comes from the fact that we use the filter also for assets, and there we only want to include metadata links.

@silvester-pari silvester-pari linked a pull request Jan 31, 2025 that will close this issue
4 tasks
@silvester-pari
Copy link
Collaborator

I have added a proposed fix in #1513 which allows all roles. I am assuming that we want to display all provider roles licensor, producer, processor and host (reference).

@santilland
Copy link
Member Author

Yes, all roles should be displayed, thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stacinfo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants