Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test to ensure that 'pip check' doesn't return any broken requirements for installed Python packages in compat layer #144

Open
boegel opened this issue Nov 29, 2021 · 5 comments · May be fixed by #210
Open

add test to ensure that 'pip check' doesn't return any broken requirements for installed Python packages in compat layer #144

boegel opened this issue Nov 29, 2021 · 5 comments · May be fixed by #210

Comments

@boegel
Copy link
Contributor

boegel commented Nov 29, 2021

Works fine for 2021.06 compat layer:

[kehoste@login1 ~]$ /cvmfs/pilot.eessi-hpc.org/2021.06/compat/linux/x86_64/startprefix
Entering Gentoo Prefix /cvmfs/pilot.eessi-hpc.org/2021.06/compat/linux/x86_64
bash: module: command not found
kehoste@login1 ~ $ pip check
No broken requirements found.

But in the draft 2021.12 compat layer (built with playbook from #140):


eessi@ip-172-31-25-60 ~/software-layer/software-layer $ which pip
/cvmfs/pilot.eessi-hpc.org/2021.12/compat/linux/aarch64/usr/bin/pip
eessi@ip-172-31-25-60 ~/software-layer/software-layer $ pip check
gitpython 3.1.24 requires typing-extensions, which is not installed.

This is most likely an upstream issue in Gentoo (missing dependency)...
@bedroge
Copy link
Collaborator

bedroge commented Nov 30, 2021

Opened a Gentoo bug report, as it looked like an issue with the ebuild file: https://bugs.gentoo.org/827882

@bedroge
Copy link
Collaborator

bedroge commented Nov 30, 2021

Actually it was a bug in the requirements.txt of GitPython itself, as they no longer need it:
https://github.com/gitpython-developers/GitPython/blob/3.1.24/git/types.py#L10

Gentoo quickly fixed it by adding a workaround in the new ebuild file:
gentoo/gentoo@4af18f3

@bedroge bedroge closed this as completed Nov 30, 2021
@boegel
Copy link
Contributor Author

boegel commented Nov 30, 2021

I think we should add pip check to our set of tests for compat layer, so I'll re-open this.

@boegel boegel reopened this Nov 30, 2021
@bedroge
Copy link
Collaborator

bedroge commented Nov 30, 2021

Oh, sorry, that makes sense, indeed. I overlooked that making a test was part of the issue...

@boegel
Copy link
Contributor Author

boegel commented Nov 2, 2022

See also #152 (which is a duplicate, I guess)

@bedroge bedroge linked a pull request Jan 6, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ReFrame test that runs pip check and modify the ld.gold check bedroge/compatibility-layer
2 participants
@boegel @bedroge