Fix Lost Particle w/ Runtime Attr #795
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some processes and/or diagnostics, we add extra runtime attributes to our beam (particle container). The logic that collected "lost" particles in the beamline, i.e., as marked as lost in apertures, did not account for extra runtime attributes and thus got lost in bookkeeping. This fixes the collection logic to be more robust and also copy any extra runtime attributes over to the "lost" particle recording. This was first seen with an input that used the nonlinear lens (NLL), NLL-invariant diagnostics and an aperture at the same time.
ax3l
added
bug
ax3l
commented
Jan 11, 2025
src/particles/CollectLost.cpp
Outdated
Comment on lines
60
to
65
| // Check destination has the same attributes as source + "s_lost" | ||
| for (auto & name : source.GetRealSoANames()) | ||
| { | ||
| if (!dest.HasRealComp(name)) { | ||
| dest.AddRealComp(name); | ||
| } |
There was a problem hiding this comment.
@atmyers question for you: we use amrex::filterAndTransformParticles below.
I am a bit afraid that when the order of attributes added in dest is not 100% the same as in source that this gets confused.
In particular, the attributes in source are something like:
- x,y,t,px,py,pt,I,H
and indest - x,y,t,px,py,pt,s,I,H
s, I and H are runtime components, all are Real.
Will that lead to broken/mismatched or partial copies from source to dest?
There was a problem hiding this comment.
I tried to add a few asserts, but maybe we need to generalize with new helper methods/functions for copies that help with the matching a bit, to simplify complex bookkeeping.
ax3l
changed the title
ax3l
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some processes and/or diagnostics, we add extra runtime attributes to our beam (particle container). The logic that collected "lost" particles in the beamline, i.e., as marked as lost in apertures, did not account for extra runtime attributes and thus got lost in bookkeeping.
This fixes the collection logic to be more robust and also copy any extra runtime attributes over to the "lost" particle recording.
This was first seen with an input that used the nonlinear lens (NLL), NLL-invariant diagnostics and an aperture at the same time. Fix #762