Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub action for code organization: Create quality.yml #62

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

arshar2411
Copy link
Contributor

Runs black for formatting, isort for organizing imports, and autoflake for removing unused imports and variables

Runs black for formatting, isort for organizing imports, and autoflake for removing unused imports and variables
@arshar2411 arshar2411 linked an issue Nov 14, 2023 that may be closed by this pull request
@RishabhSaini
Copy link
Contributor

See suggested changes here to auto format on push: #61 (comment)

@RishabhSaini
Copy link
Contributor

I would avoid pushing a Linted code on main when a PR is made to main
Instead push a linted version to main, when the PR is merged

@RishabhSaini
Copy link
Contributor

Only perform the commit and push when

on:
  push:
    branches:
      - main

@RishabhSaini
Copy link
Contributor

It would still hit 403 upon merging since GihtubActions Bot is not a member of ECE444-2023Fall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI must do Linting and Formatting Checks
2 participants