Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it necessary to have the Default suffix on output variables like SshCellDefault? #178

Open
xylar opened this issue Dec 4, 2024 · 2 comments
Labels
question Further information is requested

Comments

@xylar
Copy link

xylar commented Dec 4, 2024

This feels awkward to me because the suffix Default has no context in most output files.

@xylar xylar added the question Further information is requested label Dec 4, 2024
@philipwjones
Copy link

Yes, I noticed this too and for most other classes (eg State, Tracer) we avoid adding the default suffix so we should be consistent here. Personally, I also think it's unnecessary to have mesh location (Cell, Edge, Vertex) in the name when it is the default location, but that opinion may not be universally held and it could still be useful for some fields where it might not be obvious.

@xylar
Copy link
Author

xylar commented Dec 4, 2024

I would also prefer to just call the variable Ssh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants