Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: incomplete intermediate results plotting needs to be redone/completed #46

Open
carynbear opened this issue May 21, 2024 · 2 comments

Comments

@carynbear
Copy link
Collaborator

carynbear commented May 21, 2024

See merged pull request: #45

Sorry needed to do this for a deadline.

@carynbear carynbear self-assigned this May 21, 2024
@carynbear carynbear added the bug Something isn't working label May 21, 2024
@carynbear carynbear changed the title Hacky/Incomplete intermediate results plotting needs to be redone feat: incomplete intermediate results plotting needs to be redone/completed Jul 2, 2024
@carynbear
Copy link
Collaborator Author

carynbear commented Jul 2, 2024

@sameerashahh is working on this.

  • Trunk-based development.
  • See 03716a0 for an example
  • Please have each system plotting code as a separate pull request

For each system,

  • Must have a function called

    **def save_plotted_trajectories( self, 
                y_true:np.ndarray, 
                y_pred: np.ndarray,
                filepath: str,
                tag: str = "", 
            ):**
            ....
    		**fig, ax = plot**([y_true, y_pred], 
    		               target_dim=min(self._embed_dim, 3), 
    		               labels=["true", "pred"], 
    		               max_lines=10,
    		               title=f"LV (C) l={self.latent_dim}, e={self._embed_dim} - {tag}")
    		**fig.savefig**(filepath, bbox_inches='tight', dpi=300, transparent=True, format='pdf')
    		**return fig, ax**
    

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant