Machine ID inconsistent between logins

[Sadzurami]

Describe the bug

For machine id creation SteamUser uses account_name | steamid, while SteamSession only uses account_name as account identifier.

When we logs using SteamUser with refresh token, instance will use steamid, we can't pass account_name.
While SteamSession used account_name while refresh token was created.

node-steam-user/components/09-logon.js

Lines 122 to 135 in 686d773

	if (details.refreshToken) {
	// If logging in with a refresh token, we need to make sure that no conflicting properties are set
	let disallowedProps = [
	'account_name',
	'password',
	'auth_code',
	'two_factor_code'
	];
	disallowedProps.forEach((prop) => {
	if (this._logOnDetails[prop]) {
	throw new Error(`Cannot specify ${prop} when logging in with a refresh token`);
	}
	});

node-steam-user/resources/default_options.js

Lines 26 to 28 in 686d773

	module.exports = {
	autoRelogin: true,
	machineIdType: EMachineIDType.AccountNameGenerated,

node-steam-user/components/09-logon.js

Lines 581 to 588 in 686d773

	// The user wants to use a machine ID that's generated off the account name
	if (this.options.machineIdType == EMachineIDType.AccountNameGenerated) {
	return createMachineID(
	this.options.machineIdFormat[0].replace(/\{account_name\}/g, this._getAccountIdentifier()),
	this.options.machineIdFormat[1].replace(/\{account_name\}/g, this._getAccountIdentifier()),
	this.options.machineIdFormat[2].replace(/\{account_name\}/g, this._getAccountIdentifier())
	);
	}

node-steam-user/components/09-logon.js

Lines 598 to 602 in 686d773

	_getAccountIdentifier() {
	return this._logOnDetails.account_name
	|| this._logOnDetails._newAuthAccountName
	|| this._logOnDetails._steamid.toString();
	}

Versions

5.2.0

[Sadzurami]

Proposal: allow to pass account_name to logOn options.

[Sadzurami]

Also proposal, but not related this issue: move functions like 'createMachineId' and 'createMachineName', which uses by
both SteamUser and SteamSession, to separate package, like @doctormckay/stdlib/hardware or @doctormckay/steam-hardware or smth like that. Main idea - keep consistency between packages, that consumes that functional.

[Sadzurami]

Also proposal: allow to pass machine_id directly to logOn method, like it implemented in SteamSession options.