Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent {DECR}: Error message for out-of-range OR non-number values differs from Redis error message #763

Closed
mghildiy opened this issue Sep 28, 2024 · 7 comments

Comments

@mghildiy
Copy link
Contributor

Steps to reproduce

SET mykey "234293482390480948029348230948"
DECR mykey
SET mykey "Hello"
DECR mykey

Expected output

The expected output when the above set of commands when run on Redis

(error) value is not an integer or out of range

Observed output

The observed output when the above set of commands when run on DiceDB

(error) ERROR WRONGTYPE Operation against a key holding the wrong kind of value

The steps to run the test cases are mentioned in the README of the dice-tests repository.

Expectations for resolution

This issue will be considered resolved when the following things are done

  1. changes in the dice code to meet the expected behavior
  2. Successful run of the tcl test behavior

You can find the tests under the tests directory of the dice repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally

@mghildiy
Copy link
Contributor Author

This issue has been raised based on findings for issue.

@ashutoshdhande
Copy link
Contributor

@mghildiy , are your expected and observed cases referring to the same scenario? I ran the same scenario as you, but encountered the same error for both (which is expected).
image

@mghildiy
Copy link
Contributor Author

@mghildiy , are your expected and observed cases referring to the same scenario? I ran the same scenario as you, but encountered the same error for both (which is expected). image

Error message needs to be same as redis.

@adityaa-p
Copy link

@mghildiy The current error message is the same as redis only. Can you please recheck?

@mghildiy
Copy link
Contributor Author

For Redis:

Screenshot 2024-09-29 at 7 42 31 AM

For dice:

Screenshot 2024-09-29 at 7 41 02 AM

I am running latest docker versions for both.

@apoorvyadav1111
Copy link
Contributor

Hi @mghildiy , I tried running latest dice db code using go and I am getting following:
image

@mghildiy
Copy link
Contributor Author

Master branch exhibits same bheaviour as redis while my findings were based on latest dokcer image.
I am closing this ticket.

@mghildiy mghildiy closed this as not planned Won't fix, can't repro, duplicate, stale Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants