Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react-redux/no-unused-prop-types] rule false positive on props defined as strings in ts interface #53

Open
JustFly1984 opened this issue Jul 27, 2020 · 2 comments
Open

[react-redux/no-unused-prop-types] rule false positive on props defined as strings in ts interface #53

JustFly1984 opened this issue Jul 27, 2020 · 2 comments

Comments

@JustFly1984
Copy link

there was no error until I have updated react-redux to the latest version [email protected]

Screenshot 2020-07-27 15 00 23
@JustFly1984 JustFly1984 changed the title react-redux/no-unused-prop-types false positive on props defined as strings in ts interface [react-redux/no-unused-prop-types] rule false positive on props defined as strings in ts interface Jul 27, 2020
@DianaSuvorova
Copy link
Owner

@JustFly1984, thanks for reporting this. Not sure I follow - would you be able to provide a min code sample to repro the issue.

@JustFly1984
Copy link
Author

@DianaSuvorova The problem is that your plugin doesn't consider aria-label or aria-hidden as valid prop, may be cos it is reassigned to ariaLabel/ariaHidden in component props destructuring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DianaSuvorova @JustFly1984