Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style ballot dashboard page #49

Open
11 of 27 tasks
virgile-dev opened this issue Apr 22, 2018 · 12 comments
Open
11 of 27 tasks

Style ballot dashboard page #49

virgile-dev opened this issue Apr 22, 2018 · 12 comments

Comments

@virgile-dev
Copy link
Member

virgile-dev commented Apr 22, 2018

Parent #69

THE BALLOT

  • Layout CSS
  • Style to designs
  • Get a ballot title
  • Get posted by
  • Add time stamp for posted date
  • vote % on yes and no
  • vote data on yes and no
  • get cast votes data
  • get number of undecided votes data

YOUR ACTION

  • Layout CSS
  • Style to designs
  • Add tooltip
  • vote tab and delegation tab
  • radio buttons for yes and no options
  • vote button
  • revoke vote button
  • get list of potential delegates in dropdown
  • You delegated x votes to [user] for this ballot
  • revoke delegation button
  • transaction status

LIQUID DEMOCRACY REPRESENTATION

  • Layout CSS
  • Style to designs
  • add tooltip
  • add tabs
  • vote graph for yes
  • vote graph for no
  • vote graph for undecided

See #57 for delegate tab.

@virgile-dev virgile-dev modified the milestones: Contracts v0.1.1, Dapp v0.2 Apr 22, 2018
@virgile-dev
Copy link
Member Author

Vote on ballot
capture d ecran 2018-04-22 a 15 25 02

Revoke delegation on ballot
capture d ecran 2018-04-22 a 15 21 16

@AlexJupiter AlexJupiter removed this from the Dapp v0.2 milestone May 19, 2018
@AlexJupiter
Copy link
Member

New designs for this: https://www.figma.com/file/Eo76kM4frkNFRBjvtvGKCNqc/Sovereign-UI-toolkit?node-id=846%3A0

image

@aecc
Copy link
Collaborator

aecc commented May 23, 2018

Looks amazing

@LucasIsasmendi LucasIsasmendi changed the title finish ballot page front end integration Style ballot detail page May 26, 2018
@AlexJupiter
Copy link
Member

AlexJupiter commented May 29, 2018

@LucasIsasmendi now I've made progress with the design system, I'll be able to crack on with some of these points above this week. Are the above completed/in-completed tasks above still accurate with your side?

@AlexJupiter
Copy link
Member

@LucasIsasmendi do you know why the active tab state isn't working?

@LucasIsasmendi
Copy link
Member

No idea, we need more front end power

@AlexJupiter AlexJupiter changed the title Style ballot detail page Style ballot dashboard page Jun 2, 2018
@medied
Copy link
Member

medied commented Jun 7, 2018

@AlexJupiter @LucasIsasmendi could you guys elaborate on the issue here? Trying to debug

@AlexJupiter
Copy link
Member

@medied are you are to click on the delegates tab, on the ballot dashboard, to see the list of delegates?

When I click on "delegate" this is the error I see:
image

@medied
Copy link
Member

medied commented Jun 11, 2018

@AlexJupiter was able to replicate that tab behavior and fixed it with c8b2e1a. Looks like it was originally set correctly with 35fba64 but got messed up with 3c3eb12.

Does this resolve the blocker for you? Seems there are some thing things that are still broken with ballot-dashboard but I'm actually not sure because I'm likely out of context. Let me know though, if there are more bugs indeed we should list them out as separate issues. Thinking we could probably benefit from a brief 15-minute video call with @LucasIsasmendi just to sort this stuff out.

@AlexJupiter
Copy link
Member

@medied apologies about the delayed reply, however I think I said this in the catchup on Monday, you've resolved my blockers. So thank you!

@AlexJupiter
Copy link
Member

@medied I'm also struggling with DemocracyEarth/wallet#95 that needs to be completed for this issue to be closed. Would you be able to help me with this?

@medied
Copy link
Member

medied commented Jun 18, 2018

Low on bandwidth this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants