Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Nameplate Cooldown Icons Continued #295

Open
7 of 9 tasks
MysticalOS opened this issue Oct 26, 2023 · 7 comments
Open
7 of 9 tasks

[Feature] Nameplate Cooldown Icons Continued #295

MysticalOS opened this issue Oct 26, 2023 · 7 comments
Labels
🛠 Enhancement New feature or request Medium Priority This issue doesn't make DBM unusable, but makes it less useful until complete

Comments

@MysticalOS
Copy link
Member

MysticalOS commented Oct 26, 2023

  • Add ability to configure cooldown text same way plater has. (on, off, size)
  • Add ability to configure header text. (on, off, size)
  • Make them click through icons
  • Investigate reports of callback errors
  • Add a test mode that can be triggered via button I'll put in GUI so users can test their settings, including a callback so if Plater is being used instead of DBM, Plater can be put into test mode via DBMs button sending request.
  • All dungeon mods migrated to nameplate only timer objects. Core changed to fully recognize these objects as now in operation and old hack to terminate regular timer objects with GUIDS now removed.
  • Performance optimizing
  • Demo might reported not working
  • Double countdown text with Omni CC
@MysticalOS MysticalOS added Medium Priority This issue doesn't make DBM unusable, but makes it less useful until complete 🛠 Enhancement New feature or request labels Oct 26, 2023
@cont1nuity
Copy link
Contributor

Maybe: additional option to separate growth direction from anchor. The current name of the option is misleading towards what it actually does: setting the growth direction for the icons AND anchoring.

@cont1nuity
Copy link
Contributor

  • Add a test mode that can be triggered via button I'll put in GUI so users can test their settings, including a callback so if Plater is being used instead of DBM, Plater can be put into test mode via DBMs button sending request.

This is done in Plater and prepared for DBM.

@MysticalOS
Copy link
Member Author

Performance note. Nameplates registers callbacks even if it doesn't need to (ie plater installed). They return end if not actually being used but it's a small micro optimize to avoid registering them at all just to go "nevermind" every event.

TODO:

  1. Register callback and unregister callback wrapper function made that basically says "if enabled and (not handoff or not plater) and callbacks not registered then register callbacks. and the reverse check for if callbacks registered and toggle is off yada yada unregister them. Able to be called externally so function can run on UI option toggle in the GUI
  2. On module initialized used to also call above function to register callbacks on load.

@MysticalOS
Copy link
Member Author

MysticalOS commented Oct 31, 2023

Err wait, nameplates isn't even a module so doesn't have OnModuleLoad ability :D wonder if nameplates should be moved to modular code. Probably too much refactoring to do that (and it might not even be efficient to do so), so guess it'd just need it's own onload check.

@cont1nuity
Copy link
Contributor

I think the hand-off change to not register if another addon is present might make sense. Question is: when do we register (or not)?
Do we want to listen to "ADDON_LOADED" here?
Or simply un-register once we hit a hand-off situation?

@cont1nuity
Copy link
Contributor

As a note: I have not seen any errors in the callbacks.

@cont1nuity
Copy link
Contributor

First two points are taken care of in #359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 Enhancement New feature or request Medium Priority This issue doesn't make DBM unusable, but makes it less useful until complete
Projects
None yet
Development

No branches or pull requests

2 participants