-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Nameplate Cooldown Icons Continued #295
Comments
Maybe: additional option to separate growth direction from anchor. The current name of the option is misleading towards what it actually does: setting the growth direction for the icons AND anchoring. |
This is done in Plater and prepared for DBM. |
Performance note. Nameplates registers callbacks even if it doesn't need to (ie plater installed). They return end if not actually being used but it's a small micro optimize to avoid registering them at all just to go "nevermind" every event. TODO:
|
Err wait, nameplates isn't even a module so doesn't have OnModuleLoad ability :D wonder if nameplates should be moved to modular code. Probably too much refactoring to do that (and it might not even be efficient to do so), so guess it'd just need it's own onload check. |
I think the hand-off change to not register if another addon is present might make sense. Question is: when do we register (or not)? |
As a note: I have not seen any errors in the callbacks. |
First two points are taken care of in #359 |
The text was updated successfully, but these errors were encountered: