Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix / Optimize PlayerSession Restoration #9

Open
DavisDevelopment opened this issue Aug 15, 2018 · 0 comments
Open

Fix / Optimize PlayerSession Restoration #9

DavisDevelopment opened this issue Aug 15, 2018 · 0 comments
Assignees
Labels
enhancement feature plan description including technical details regarding the implementation of a feature performance problems and/or suggestions regarding app's performance player related to the Player system redesign / restructure needed/pending changes to existing systems ui

Comments

@DavisDevelopment
Copy link
Owner

The Goal

The end-goal here is to just generally improve session persistence and restoration, both computationally and visually. Visually, the experience of restoring a previous session is fairly jarring when there's visual media involved, and starts to approach frightening if multiple tabs are also involved. This tantrum will often last for as long as 20-30sec, and then everything normalizes.
I'm pretty confident that all of this weirdness can be fixed with a new algorithm for restoring a serialized session.

The Current Implementation

  1. (repeat for each serialized Tab)
    1. create empty Tab
    2. build a media-queue for it
    3. attach restored queue to the blank Tab
    4. find and focus the Tab's active Track
  2. shift focus to the active Tab
  3. mount 'now-playing' track for playback
  4. initiate loading of TrackDatas for all restored tracks, all at once, in alphabetical order

Specification for New Implementation

@DavisDevelopment DavisDevelopment added performance problems and/or suggestions regarding app's performance enhancement player related to the Player system ui feature plan description including technical details regarding the implementation of a feature redesign / restructure needed/pending changes to existing systems labels Aug 15, 2018
@DavisDevelopment DavisDevelopment self-assigned this Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature plan description including technical details regarding the implementation of a feature performance problems and/or suggestions regarding app's performance player related to the Player system redesign / restructure needed/pending changes to existing systems ui
Projects
None yet
Development

No branches or pull requests

1 participant