Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value undefined #13

Open
0rion7st opened this issue Dec 25, 2015 · 2 comments
Open

Value undefined #13

0rion7st opened this issue Dec 25, 2015 · 2 comments

Comments

@0rion7st
Copy link

If the value undefined element throws an error.

Recommended fix:
paper-color-input.html:198
_isValueDefined: function(){
return this.value && this.value.red >= 0 && this.value.green >= 0 && this.value.blue >= 0;
},

@David-Mulder
Copy link
Owner

Does that recommended fix actually work for you? Because I am pretty sure it will not and if it does not I fear I will have to simply say that to set the component as undefined you need to set value to {red: undefined, green: undefined, blue: undefined} like the default. Oh well, don't have much time now, but might check later.

@0rion7st
Copy link
Author

I'm creating complex system (~20 components currently) trying to make each element bulletproof for insertion of jsons of any kind of data. At least unobtrusive error checking which prevents elements for erroring out. Probably matter of taste, however I can't imagine that some of native html elements (

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants