Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TC: attribute.create does not have a "force" parameter #352

Open
pcattori opened this issue Apr 2, 2020 · 0 comments
Open

TC: attribute.create does not have a "force" parameter #352

pcattori opened this issue Apr 2, 2020 · 0 comments
Labels
🐛 Bug Something isn't working 📝 Docs Documentation-only changes good first issue Good for newcomers

Comments

@pcattori
Copy link
Contributor

pcattori commented Apr 2, 2020

🐛 bug report

Docstring for tc.attribute.create includes a force parameter, but the function does not have such a parameter.

🤔 Expected Behavior

Docstring should not contain force param.

😯 Current Behavior

Docstring contains force param.

💁 Possible Solution

Remove force param from tc.attribute.create docstring

🔦 Context

Originally, the force parameter was used to skip reserved attribute name checking, but since we have tc.attribute._create (note the leading _) for that exact purpose, we no longer needed the force parameter. That parameter was removed, but the docstring erroneously kept it.

💻 Code Sample

N/A

🌍 Your Environment

tamr_client

Software Version(s)
tamr-unify-client 0.11.0-dev
Tamr server n/a
Python 3.6.5
Operating System MacOS
@pcattori pcattori added 🐛 Bug Something isn't working 📝 Docs Documentation-only changes labels Apr 2, 2020
@skalish skalish added the good first issue Good for newcomers label Apr 13, 2020
@pcattori pcattori changed the title attribute.create does not have a "force" parameter TC: attribute.create does not have a "force" parameter Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 📝 Docs Documentation-only changes good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants