Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove render blocking resources from web proxy #73

Open
3 tasks
amoeba opened this issue Aug 8, 2022 · 0 comments
Open
3 tasks

Remove render blocking resources from web proxy #73

amoeba opened this issue Aug 8, 2022 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@amoeba
Copy link
Contributor

amoeba commented Aug 8, 2022

The HTML template the web proxy uses puts two render-blocking resources in the head tag. I noticed this because loading the page is noticeably slow. We should move these down into the end of the body so they don't render-block.

<link href="https://api.test.dataone.org/slinky/static/css/base.css" rel="stylesheet">
<link href="https://api.test.dataone.org/slinky/static/css/index.css" rel="stylesheet">
<link href="https://unpkg.com/@triply/yasgui/build/yasgui.min.css" rel="stylesheet" type="text/css" />
<script src="https://unpkg.com/@triply/yasgui/build/yasgui.min.js"></script>

While we're at it, there are a few more things we should change. Here's the full list:

  • Move render-blocking resources out of the head tag
  • Serve all resources our own origin rather than unpkg
  • Don't hard-code the location of any resources, instead load resources from the appropriate location regardless of deployment context

I might make some style/layout tweaks while I'm in here too.

@amoeba amoeba added the bug Something isn't working label Aug 8, 2022
@amoeba amoeba added this to the 0.3.0 milestone Aug 8, 2022
@amoeba amoeba self-assigned this Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant