Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request restructure/reorganize repo #28

Open
hgdagon opened this issue Mar 16, 2022 · 3 comments
Open

Request restructure/reorganize repo #28

hgdagon opened this issue Mar 16, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@hgdagon
Copy link

hgdagon commented Mar 16, 2022

This might be a weird request, but if the repo is a little more organized it might (should) help new contributors to join in more easily.

  1. Arrange everything in subdirectories.
  2. Get rid of external stuff (like FT2, support latest libraries instead).
  3. Add higher res icon (256x256).
  4. Add versioning.
  5. Use LF in all files (yeah, this ones a bit subjective, considering the repo deliberately goes for CRLF).
  6. Use Github's own workflows for CI, code checks, and what not.
  7. Etc.

This can be done along with #26

@Cloudwalk9 Cloudwalk9 added the enhancement New feature or request label Mar 24, 2022
@hemebond
Copy link
Contributor

hemebond commented Sep 20, 2022

Would it not be better to have a separate issue for each of these? Perhaps use a Project to track them.

@hemebond
Copy link
Contributor

Hi @hgdagon, a few comments and questions for you:

  1. This can be tracked by Clean project directory structure for ease of manteinance #148
  2. What's the reason for getting rid of the FreeType2 stuff? Is it not used?
  3. If any artist wanted to submit a PR with a new icon that'd be great, but I don't think it needs to be an issue.
  4. Add versioning? To releases? What kind of versioning?
  5. As you say, it's explicitly set to CLRF. Why should it be LF instead? Apparently Notepad was updated in 2018 to support LF. It seems CLRF is pretty standard and I think changing to LF will break the Windows-only files in the repo, like the sln files.
  6. We now have a Github action to automatically build Linux binaries.

@bones-was-here
Copy link
Contributor

LF should already be used in all source files, it's the "native" format on git and is required for clean git diffs, and .gitattributes is configured to convert from CRLF automatically (I think you've misunderstood this file). CRLF may still be used in a few microsoft-specific files.

I don't think we'll remove the optional library headers, they're minimal versions (only the parts DP uses) so they're unlikely to break, and are needed for DP's convenient ability to dlopen optional libraries if they're installed on the system, or run without their features if not (most programs dynamically link instead and fail to compile or run if a library isn't installed). We may remove the GL declarations at some point, libGL is mandatory. SDL2 headers are already sourced from the platform.

I'll tag and build stable releases when I think it's time (got some work to do yet...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants