Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [QueryAsync] NoCache flag ignored when doing MultiMap #2113

Closed
Dot-H opened this issue Sep 17, 2024 · 2 comments
Closed

🐛 [QueryAsync] NoCache flag ignored when doing MultiMap #2113

Dot-H opened this issue Sep 17, 2024 · 2 comments

Comments

@Dot-H
Copy link

Dot-H commented Sep 17, 2024

It seems like QueryAsync when being passed the map and splitOn argument ends up ignoring the NoCache command flag.

You can see #2112 for a repro
@Dot-H
Copy link
Author

Dot-H commented Sep 17, 2024

Not sure what the best fix is TBH. Issue clearly comes from the CommandDefinition.ForCallback call here which doesn't pass on the CommandFlags.

But I am not sure why it's done that way. This ForCallback method seems to be here to ensure that the inner command only contains parameters of type DynamicParameters. I am not sure if it matters to also remove all the other attributes (including the Flags).

goerch added a commit to goerch/Dapper that referenced this issue Oct 3, 2024
@goerch
Fix DapperLib#2113
9b64ce1
@Dot-H
Copy link
Author

Dot-H commented Jan 2, 2025

Hi @mgravell 👋
Do you think we could release a minor (or an alpha) with 38df7bb in it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Dot-H