Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization since the Laravel 5 update #6

Open
mpopke opened this issue Apr 30, 2015 · 5 comments
Open

Localization since the Laravel 5 update #6

mpopke opened this issue Apr 30, 2015 · 5 comments

Comments

@mpopke
Copy link
Collaborator

mpopke commented Apr 30, 2015

Have you guys tried overriding the strings for Friends' lang.php since upgrading to the new Laravel? I've moved the file (dma/friends/lang.php) from /app/lang to /lang as the October documentation proscribes, but it's not working anymore. I've tried putting the lang directory back under /app and into a host of other places just basically shotgun debugging it, and nothing seems to work. Google/Stack/forums have turned up nothing helpful either.

Have you gotten it to work? I'm trying to determine if I've put this in the wrong place or if something is messed up on our October install or if I've actually found a bug.

@karnold
Copy link
Contributor

karnold commented Apr 30, 2015

Everything works fine for us, however we are not doing any overrides of the
language file either.

according to the laravel docs it looks like the lang.php override should be
in resources/lang/packages/{locale}/{package} however im not sure how that
relates to the plugin namespace in october unless they use the same format.

http://laravel.com/docs/5.0/localization#overriding-package-language-files

On Thu, Apr 30, 2015 at 10:39 AM, Matt Popke [email protected]
wrote:

Have you guys tried overriding the strings for Friends' lang.php since
upgrading to the new Laravel? I've moved the file (dma/friends/lang.php)
from /app/lang to /lang as the October documentation proscribes, but it's
not working anymore. I've tried putting the lang directory back under /app
and into a host of other places just basically shotgun debugging it, and
nothing seems to work. Google/Stack/forums have turned up nothing helpful
either.

Have you gotten it to work? I'm trying to determine if I've put this in
the wrong place or if something is messed up on our October install or if
I've actually found a bug.


Reply to this email directly or view it on GitHub
#6.

@mpopke
Copy link
Collaborator Author

mpopke commented Apr 30, 2015

Yeah, October moves the resources directory (and subdirectories) around. Supposedly, the root directory of the October install is the default resources directory while /storage/app/ holds things like upload and media now. It's weird because I've found a couple other people having the same problem (with different plugins), but most people report that it just works (/lang) and no one has given any resolution for those people who report problems. I've commented on an open issue with the October devs, but I'm not hopeful for a speedy outcome.

@karnold
Copy link
Contributor

karnold commented Apr 30, 2015

can you link to that issue? it might be something I can fix


Kristen

On Thu, Apr 30, 2015 at 12:00 PM, Matt Popke [email protected]
wrote:

Yeah, October moves the resources directory (and subdirectories) around. Supposedly, the root directory of the October install is the default resources directory while /storage/app/ holds things like upload and media now. It's weird because I've found a couple other people having the same problem (with different plugins), but most people report that it just works (/lang) and no one has given any resolution for those people who report problems. I've commented on an open issue with the October devs, but I'm not hopeful for a speedy outcome.

Reply to this email directly or view it on GitHub:
#6 (comment)

@mpopke
Copy link
Collaborator Author

mpopke commented Apr 30, 2015

octobercms/october#1059

@karnold
Copy link
Contributor

karnold commented May 13, 2015

according to the octobercms issue, this has since been resolved in dev. Can you let me know if that fixed the issue for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants