Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderlet:Date problems with dates in future #83

Open
SvenJuergens opened this issue Jul 6, 2018 · 6 comments
Open

renderlet:Date problems with dates in future #83

SvenJuergens opened this issue Jul 6, 2018 · 6 comments

Comments

@SvenJuergens
Copy link

Hi,

hello, there is a little problem with the method __date2timestamp if you have a dateformat like %d. %m. %y (small y) and then a date in the future. for example 01.01.19

When splitting the Dateformat, only a% Y (large Y) is searched, and if none is found, the current year is taken. At the moment the date is changed to 01.01.18

@hannesbochmann
Copy link
Member

Where is this method used? I can't find it.

@SvenJuergens
Copy link
Author

SvenJuergens commented Jul 16, 2018 via email

@hannesbochmann
Copy link
Member

Are you willing to provide a pull request including the fix and a corresponding unit test?

@SvenJuergens
Copy link
Author

hi,
at first I also tried to write a general valid patch, but in order to properly implement all possibilities of $allowedDateFormatParts I would probably have to adapt a lot more and I do not have the necessary insight into this rather complex extension. Therefore, I do not think that I could solve it clean at the moment, sorry

@hannesbochmann
Copy link
Member

No problem, we will have a look at this but I can't tell you when we got time for this.

@SvenJuergens
Copy link
Author

thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants