Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dfsu.contains() fails in some cases for global meshes #280

Open
jsmariegaard opened this issue Feb 2, 2022 · 4 comments
Open

Dfsu.contains() fails in some cases for global meshes #280

jsmariegaard opened this issue Feb 2, 2022 · 4 comments
Assignees
@jsmariegaard

Comments

@jsmariegaard
Copy link
Member

@caichac-dhi reported an issue for dfsu file made from a global mesh which is due to a problem with the determination of the boundary polyline for a global mesh.
@jsmariegaard jsmariegaard self-assigned this Feb 2, 2022
@ecomodeller
Copy link
Member

Somehow in everyday life it is easy to forget that we live on a sphere. 🌎

@ecomodeller
Copy link
Member

Related to issue #697 , i.e. not only a problem with global meshes

@daniel-caichac-DHI
Copy link
Collaborator

daniel-caichac-DHI commented Sep 6, 2024 •
edited
Loading

It is kind of addressed with this open PR right #700 ?

@ecomodeller
Copy link
Member

It is kind of addressed with this open PR right #700 ?

Yes, but I would like some feedback on it before merging it, to avoid having to revert or to fix it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsmariegaard jsmariegaard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ecomodeller @jsmariegaard @daniel-caichac-DHI