Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect errors from stepper for Proposal validation #693

Closed
miggol opened this issue Sep 4, 2024 · 0 comments · Fixed by #700
Closed

Collect errors from stepper for Proposal validation #693

miggol opened this issue Sep 4, 2024 · 0 comments · Fixed by #700
Assignees

Comments

@miggol
Copy link
Contributor

miggol commented Sep 4, 2024

It's (hopefully) time to retire validate_proposal.py!

The stepper.items list already contains all the modelform items that a proposal requires to be completed. Each has an item.errors property that will allow you to access the form errors.

Implementing this may require slightly more work than just glueing everything together. There could be quirks in validate_proposal.py and errors that get generated elsewhere than in modelform instantiation. Specifically I hope that #691 doesn't rear its head.

@EdoStorm96 EdoStorm96 self-assigned this Sep 12, 2024
@EdoStorm96 EdoStorm96 linked a pull request Sep 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants