Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Members: editing of comments #638

Closed
djhcapel opened this issue Mar 26, 2024 · 3 comments
Closed

Members: editing of comments #638

djhcapel opened this issue Mar 26, 2024 · 3 comments

Comments

@djhcapel
Copy link

In the LC, some of us remembered being able to edit comments. This does not seem possible anymore. One of us inadvertently pressed 'Enter' halfway a sentence, and could not undo that anymore. Could an editing option be re-installed? Or incorporated? Perhaps with a tick that a comment is ready?

@miggol
Copy link
Contributor

miggol commented Mar 28, 2024

Short term because this used to be possible, so if we can easily reinstate that feature then great.

However, if it turns out that this feature was removed because of some kind of complexity or bug, this can be moved to the "long term" milestone.

@tymees
Copy link
Member

tymees commented Mar 28, 2024

The problem was introduced here:
c7e2fed

The first change was restoring old behaviour, it always locked the option after all comments where in (I checked against the v2 tag). The second change locks a decision after a go/no-go is set, which was not in the pre-review-actions code.

@miggol
Copy link
Contributor

miggol commented Apr 2, 2024

Well found, Ty.

@djhcapel We'll restore the old behaviour for now: anyone can edit their feedback unless they were the final reviewer and the review enters the "To conclude" stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants