Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blackify the entire repository #553

Closed
miggol opened this issue Oct 17, 2023 · 1 comment
Closed

Blackify the entire repository #553

miggol opened this issue Oct 17, 2023 · 1 comment
Assignees
Labels
Technical Not interesting for secretary

Comments

@miggol
Copy link
Contributor

miggol commented Oct 17, 2023

We've decided to, from some point in the future onwards, commit our code formatted by black. The question remains of when we apply it to the whole back catalog of code.

There's a caveat in that pull requests which are open at time of blackification will be a little harder to merge. Perhaps we can say that once #537 is merged, we take the plunge.

To prevent every affected line referencing this commit in git blame, check out the following: https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view

@tymees tymees self-assigned this Oct 17, 2023
@tymees
Copy link
Member

tymees commented Oct 17, 2023

It might also be a good idea to add some docs to our meta repo on how to setup IDE's to run black and other tools automatically. I can do that as well

@tymees tymees added the Technical Not interesting for secretary label Nov 20, 2023
@tymees tymees closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Technical Not interesting for secretary
Projects
None yet
Development

No branches or pull requests

2 participants