Improve committee member workload overview

[EdoStorm96]

The committee member workload overview is not quite up to Desiree's wishes and should be improved:

In de eerste lijst staan aanvragen die ‘niet verder in behandeling’ zijn genomen; die mogen eruit.
In de eerste lijst staan volgens mij ook nooit of nog niet ingediende aanvragen (nl. nog bij supervisor); die mogen eruit.
Kan ik die lijst exporteren zodat ik er zelf in Excel statistiek mee kan uithalen?

In de tweede lijst ontbreken mensen (bijv. in de LK: ondergetekende, en Michael mag eruit, sorry Michael, Koen Leurs mag er ook uit; in de AK: ondergetekende ontbreekt, Hugo mag eruit).
Kan ik ook een periode aangeven voor die lijst? Betreft het nu het aantal ingevulde beoordelingen vanaf exact een jaar geleden? Of gaat het ook nog om lopende beoordelingen?
Kan ik ook te zien krijgen welke persoon welke aanvragen nog moet beoordelen?

The queryset is clearly not working properly ... And some extra features could be implemented.

[EdoStorm96]

The problems with the first list were a fairly easy solve. The initial queryset filter was just bad.

For the second list, Desiree would like to be able to set the start and end date of the period herself.

Also, this second list is now constructed by looking at all the reviewers in a chamber. This is not so great, as there are members of a chamber, who don't really do reviews (such as Michael). We should probably look at all the handled proposals of a chamber, and build up the reviewers list from there.

[djhcapel]

The second list is now constructed by looking at all the reviewers in a chamber, but the reviewers mentioned include supervisors. I would be interested to see just the members of the chamber involved in that list. Is that possible, i.e. the five members, including, me, plus Leon plus Frans.

[djhcapel]

But the first list looks great and it's also nice I can select the period for the second list!

[EdoStorm96]

Ok, I will work on it. So the members that you want to see are never/can never be the supervisor? Then it could be a pretty easy fix.

I think this is caused by the fact that supervisors are automatically also marked as reviewers, which I was unaware of ...

[djhcapel]

I only need to see members and advisory members. What happens if one of the members is the supervisor in an application?

[tymees]

Edo asked me to take a look at this issue;

I have a pretty simple fix: add an extra filter after return reviewers.annotate:
.exclude(total=0). As the total is properly set-up to filter out supervisors, this will effectively hide them from the list.

An alternative would be to limit reviewers to current committee members only, but then someone who just left the committee will never be shown. IMO, it's better to have actual history if you also have a timeline selecter.

[tymees]

For clarity, this would be the entire QS:

       return reviewers.annotate(
            total=Count("decision", filter=base_filter),
            num_short_route=Count(
                "decision",
                filter=base_filter
                & Q(
                    decision__review__proposal__is_revision=False,
                    decision__review__short_route=True,
                ),
            ),
            num_long_route=Count(
                "decision",
                filter=base_filter
                & Q(
                    decision__review__proposal__is_revision=False,
                    decision__review__short_route=False,
                ),
            ),
            num_revision=Count(
                "decision",
                filter=base_filter & Q(decision__review__proposal__is_revision=True),
            ),
        ).exclude(total=0)

[EdoStorm96]

Perfect. Thank you!

[djhcapel]

Two additional requests for the second list (Workload overview of past period):

• Please adjust format date from month-day-year to day-month-year
• Please make the default period three months instead of one year
  Thanks!

[djhcapel]

Additional request: At the moment, the upper list has all applications that still need to be reviewed by one or more people. It lists all reviewers attached to that application, independent of if they have already submitted their decision or not. If possible, I want all reviewers that have submitted a decision to be removed from the table.