Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logic to gui/rename to choose appropriate parameters to call GenerateName API #5184

Closed
myk002 opened this issue Jan 9, 2025 · 4 comments · Fixed by DFHack/scripts#1371

Comments

@myk002
Copy link
Member

myk002 commented Jan 9, 2025

needs to choose word selectors based on environment

we possibly need more UI components to allow the player to choose preferences for the generated name..

ref: #5175 (comment)

@quietust
Copy link
Member

quietust commented Jan 9, 2025

Exactly what types of names are we expecting this script to generate? Each type will likely require different parameters.

Notably, naming a Unit depends on whether it's an "Outsider" or if it belongs to a Civilization - the former will pick from the word selectors in df.global.world.raws.language, while the latter will pick from the ones in entity_raw.symbols.

@myk002
Copy link
Member Author

myk002 commented Jan 11, 2025

It currently covers:

  • the world
  • any historical_entity, though only sites, governments, and civs are selectable from inside the UI
  • units/histfigs
  • artifacts
  • locations
  • squads

@quietust
Copy link
Member

quietust commented Jan 12, 2025

  • World - language_name_type::World + world.raws.language.word_table[0/1][Region]
  • Entity - Civilization uses language_name_type::Civilization and entity_raw->symbols.symbols_major/minor[CIV], Site Government uses language_name_type::EntitySite and entity_raw->symbols.symbols_major/minor[SITE], and Sites use language_name_type::Site and entity_raw->symbols.symbols_major/minor[OTHER]
  • Unit - language_name_type::Figure; if a member of a civ, entity_raw->symbols.symbols_major/minor[OTHER], otherwise world.raws.language.word_table[0/1][Unit]
  • Artifact - language_name_type::Artifact + world.raws.language.word_table[0/1][Artifact] (or [ArtifactEvil] if it was created by a fell/macabre mood)
  • Location - what kinds of locations?
  • Squad - looks like language_name_type::Squad plus entity_raw->symbols.symbols_major/minor[OTHER]

@myk002
Copy link
Member Author

myk002 commented Jan 12, 2025

  • Location - what kinds of locations?

All, are possible, but taverns, hospitals, temples, libraries, and guildhalls are most likely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants