You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
is defined in Host.h include from other public headers (SimpleSocket.h), with guard #ifdef _MSC_VER.
however this definition might collide easily with user code using CLsocket.
i'd suggest to rename EXPORT into CLSOCKET_EXPORT ..
[ and possibly make this definition only when having an additional private definition in CMakeLists.txt, e.g. when compiling the shared library ]
The text was updated successfully, but these errors were encountered:
now have also a commit for this issue in PR #4
might need some more testing on Windows - but it got late for today.
different from my own suggestion i renamed EXPORT to CLSOCKET_API,
and also added dllimport .. and activate that only when compiling the shared library.
Looks awesome, thanks for the fix! Saves me from having to address #17 (comment). That was on my to-do list, so I'll take a closer look at #4, hopefully soon.
is defined in Host.h include from other public headers (SimpleSocket.h), with guard
#ifdef _MSC_VER
.however this definition might collide easily with user code using CLsocket.
i'd suggest to rename EXPORT into CLSOCKET_EXPORT ..
[ and possibly make this definition only when having an additional private definition in CMakeLists.txt, e.g. when compiling the shared library ]
The text was updated successfully, but these errors were encountered: