Skip to content
This repository has been archived by the owner on Jan 8, 2025. It is now read-only.

C++11 warnings result in build failure. #110

Open
edsu opened this issue Apr 23, 2019 · 1 comment
Open

C++11 warnings result in build failure. #110

edsu opened this issue Apr 23, 2019 · 1 comment

Comments

@edsu
Copy link

edsu commented Apr 23, 2019

When building on Ubuntu I'm seeing warnings like this that ultimately result in a build failure:

In file included from /code/libmei-3.1.0/src/meiattribute.cpp:2:0:
/code/libmei-3.1.0/src/meielement.h:181:44: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
         void setDocument(MeiDocument *doc) throw (DocumentRootNotSetException);

Normally warnings are not considered errors, but the compiler is being asked to make them errorrs. When I remove those lines the build succeeds.

@mprevot
Copy link

mprevot commented Jul 16, 2019

For non developers, adding add_definitions( -w ) to silent warnings is also a good thing to do.

JRegimbal added a commit to JRegimbal/libmei that referenced this issue Jul 22, 2020
Since some features are deprecated (and more possibly will be
eventually), keep errors on warnings (-Werror) but also add an exception
to just warn on deprecation (-Wno-error=deprecated) rather than fail.

This keeps deprecation warnings visible and also causes more serious
warnings (like uninitialized variables/pointers) to error.

This addresses issue DDMAL#110.
JRegimbal added a commit to JRegimbal/libmei that referenced this issue Aug 7, 2020
Since some features are deprecated (and more possibly will be
eventually), keep errors on warnings (-Werror) but also add an exception
to just warn on deprecation (-Wno-error=deprecated) rather than fail.

This keeps deprecation warnings visible and also causes more serious
warnings (like uninitialized variables/pointers) to error.

This addresses issue DDMAL#110.
rettinghaus pushed a commit to eNote-GmbH/libmei that referenced this issue Jul 1, 2022
Since some features are deprecated (and more possibly will be
eventually), keep errors on warnings (-Werror) but also add an exception
to just warn on deprecation (-Wno-error=deprecated) rather than fail.

This keeps deprecation warnings visible and also causes more serious
warnings (like uninitialized variables/pointers) to error.

This addresses issue DDMAL#110.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants