Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why are we testing so many tags in liberupdatev5 with endswith method? #14

Open
dchiller opened this issue Jun 10, 2024 · 1 comment
Open

Why are we testing so many tags in liberupdatev5 with endswith method? #14

dchiller opened this issue Jun 10, 2024 · 1 comment
Labels
question Further information is requested

Comments

@dchiller
Copy link
Contributor

See, for example, here:

https://github.com/DDMAL/MEI3to5/blob/825c32e0f123067e2b29547a3057c305b36e83fd/liberupdatev5.py#L19C1-L26C67

Why are we using the endswith method rather than checking equality?
@dchiller dchiller added the question Further information is requested label Jun 10, 2024
@CThierrin
Copy link
Contributor

Sometimes the namespace prefix is added to the element tag. This allows the code to work regardless of whether it's there or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dchiller @CThierrin