Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex lets wrong 7th-chords pass #42

Open
johentsch opened this issue Mar 8, 2021 · 0 comments
Open

Regex lets wrong 7th-chords pass #42

johentsch opened this issue Mar 8, 2021 · 0 comments

Comments

@johentsch
Copy link
Member

The specifiers M % +M can only occur in seventh chords and therefore one of 7 65 43 2 needs to follow it. Since form and figbass are defined in two separate groups, the regex matches even if figbass is missing. To improve the regex would probably require lookaheads. Or we check that elsewhere and/or do some automatic correction, just assuming 7?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant