Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible bugs in LR scheduler #154

Open
SAGNIKMJR opened this issue Apr 11, 2024 · 0 comments
Open

Possible bugs in LR scheduler #154

SAGNIKMJR opened this issue Apr 11, 2024 · 0 comments

Comments

@SAGNIKMJR
Copy link

Hi, do you think the following could be bugs in the lr scheduler?

  1. Video-LLaMA/video_llama/common/optims.py

    Line 83 in ae12557

    step=cur_step,
    should be step=total_cur_step,?

  2. Video-LLaMA/video_llama/common/optims.py

    Line 91 in ae12557

    epoch=total_cur_step,
    should be epoch=total_cur_step - self.warmup_steps,?

  3. Video-LLaMA/video_llama/common/optims.py

    Line 93 in ae12557

    max_epoch=self.max_epoch * self.iters_per_epoch,
    should be max_epoch=self.max_epoch * self.iters_per_epoch - self.warmup_steps,?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SAGNIKMJR