From 6caf7fbe1ebee57d59ffd4d7742c005d54d38fe6 Mon Sep 17 00:00:00 2001
From: Cyrille Bougot <cyrille.bougot2@laposte.net>
Date: Mon, 4 Sep 2023 16:49:14 +0200
Subject: [PATCH] Release 5.0

---
 .github/workflows/testAddon.yml | 59 ---------------------------------
 buildVars.py                    |  4 +--
 readme.md                       | 11 ++++++
 3 files changed, 13 insertions(+), 61 deletions(-)
 delete mode 100644 .github/workflows/testAddon.yml

diff --git a/.github/workflows/testAddon.yml b/.github/workflows/testAddon.yml
deleted file mode 100644
index 2ea2883..0000000
--- a/.github/workflows/testAddon.yml
+++ /dev/null
@@ -1,59 +0,0 @@
-name: Check that all translatable strings have translators comments
-
-on:
-  push:
-    # Run this workflow if push tag or in master branch
-    tags: ["*"]
-    branches: [ main , master ]
-
-  workflow_dispatch:
-
-jobs:
-  buildPotFileAndCheckTranslatorsComments:
-
-    runs-on: ubuntu-latest
-
-    steps:
-    - name: Checkout code
-      uses: actions/checkout@v3
-
-    - name: Set up Python 3.8
-      uses: actions/setup-python@v4
-      with:
-        python-version: 3.8
-
-    - name: Install dependencies
-      run: |
-        pip install scons markdown
-        sudo apt update
-        sudo apt install gettext
-    
-    - name: Generate the .pot file
-      run: scons pot
-
-    - name: Download NVDA's checkPot.py
-      run: curl https://raw.githubusercontent.com/nvaccess/nvda/master/tests/checkPot.py -O
-
-    - name: Run checkPot
-      id: runCheckPot
-      #run: |
-      #  from . import checkPot
-      #  checkPot.EXPECTED_MESSAGES_WITHOUT_COMMENTS = set()
-      #  res = checkPot.checkPot('$(ls *.pot)')
-      #  exit(res)
-      #shell: python 
-      run: |
-        python -c "import checkPot;checkPot.EXPECTED_MESSAGES_WITHOUT_COMMENTS = set();exit(checkPot.checkPot('$(ls *.pot)'))"
-        echo "nb_errors=$?" >> "$GITHUB_OUTPUT"
-
-    - name: Notify
-      run: |
-        if [[ ${{ steps.runCheckPot.outputs.nb_errors }} == 0 ]];
-        then
-        echo "Translators comments: PASS"
-        exit 0;
-        else
-        echo "Translators comments: FAIL"
-        exit 1;
-        fi
-      
\ No newline at end of file
diff --git a/buildVars.py b/buildVars.py
index 5f3fb51..677cfb9 100644
--- a/buildVars.py
+++ b/buildVars.py
@@ -25,7 +25,7 @@ def _(arg):
 	# Translators: Long description to be shown for this add-on on add-on information from add-ons manager
 	"addon_description": _("""A set of tools for NVDA developers and testers."""),
 	# version
-	"addon_version": "4.2",
+	"addon_version": "5.0",
 	# Author(s)
 	"addon_author": "Cyrille Bougot <cyrille.bougot2@laposte.net>",
 	# URL for the add-on documentation support
@@ -37,7 +37,7 @@ def _(arg):
 	# Minimum NVDA version supported (e.g. "2018.3.0", minor version is optional)
 	"addon_minimumNVDAVersion": "2019.2",
 	# Last NVDA version supported/tested (e.g. "2018.4.0", ideally more recent than minimum version)
-	"addon_lastTestedNVDAVersion": "2023.1",
+	"addon_lastTestedNVDAVersion": "2023.2",
 	# Add-on update channel (default is None, denoting stable releases,
 	# and for development releases, use "dev".)
 	# Do not change unless you know what you are doing!
diff --git a/readme.md b/readme.md
index 9841505..4e0b9b3 100644
--- a/readme.md
+++ b/readme.md
@@ -273,6 +273,17 @@ These settings only take effect at next NVDA startup when the backup takes place
 
 ## Change log
 
+### Version 5.0
+
+* If Instant Translate add-on is installed, it is now possible to have speech messages translated on the fly when using log reading commands.
+* While in log reading mode, pressing E or shift+E now jumps to CRITICAL erorr messages as well as normal ERROR messages.
+* New log quick navigation commands have been added to jump to input and to speech messages.
+* A new command allow to place a marker in the log; and specific quick navigation commands in log reading mode allow to jump to them.  
+  Credit: the initial idea for this feature comes from Debug Helper add-on by Luke Davis.
+* Bubfix: The memorization of the last error do not fail anymore in some cases.
+* Bugfix: The add-on can initialize again with NVDA 2019.2.1.
+* Bugfix: Log saving feature will not fail anymore with non-ASCII logs.
+
 ### Version 4.2
 
 * Fixed an error with NVDA version below 2021.3.