Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

OPCode/QueryID 6 should check the latest Blockhash and timestamp #16

Open
michelbarnich opened this issue Dec 16, 2022 · 3 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@michelbarnich
Copy link
Contributor

To prevent the Network from de-syncing completely, when a Node fails to accept a new Block, the QID/OPCode 6 should also request the newest Blockhash. This way if a Node didnt accept the newest Block, it will automatically be removed from the network, and not hinder the Network in accepting and validating new Blocks.

@michelbarnich michelbarnich added the enhancement New feature or request label Dec 16, 2022
@michelbarnich michelbarnich self-assigned this Dec 16, 2022
@michelbarnich
Copy link
Contributor Author

michelbarnich commented Dec 17, 2022

I created a first implementation for this in commit 27e4380. Stability needs to be tested in the next few test runs. It should be just as stable as previous OPCode 6.

@michelbarnich
Copy link
Contributor Author

When a Node was rejected by the Network, and it goes offline, it may cause a desync in the Network. I am not 100% sure if this is the cause though.

@michelbarnich
Copy link
Contributor Author

The reachability check will now be executed 30 seconds after each full minute (commit f83818d), the desync was probably caused by the check happening at a inconvenient moment in time (one Node already rejected another, while others havent realized yet)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant