-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Full XReference Cache System #151
Merged
RadWolfie
merged 12 commits into
Cxbx-Reloaded:master
from
RadWolfie:full-xref-cache-system
Nov 8, 2021
Merged
Feature: Full XReference Cache System #151
RadWolfie
merged 12 commits into
Cxbx-Reloaded:master
from
RadWolfie:full-xref-cache-system
Nov 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CMAKE
D3D8
OOVPA relative topic
D3D8LTCG
OOVPA relative topic
DSOUND
OOVPA relative topic
JVS
OOVPA relative topic
needs-verification
Require verification before approval
OOVPA
Any OOVPA change relative
XACTENG
OOVPA relative topic
XAPI
OOVPA relative topic
XNET
OOVPA relative topic
XONLINE
OOVPA relative topic
labels
Nov 4, 2021
This change will reveal errors, next commit will resolve new errors.
plus remove unused XRefNoSaveIndex define and xref from revisions
RadWolfie
force-pushed
the
full-xref-cache-system
branch
from
November 4, 2021 19:16
f1d54f0
to
0248a90
Compare
RadWolfie
force-pushed
the
full-xref-cache-system
branch
from
November 7, 2021 18:51
f0315ea
to
218f4ed
Compare
Tested and verified no breakage against master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in draft at the moment, reasons:Need to migrate various altered symbol names into single xref usage. (will be done in separate commit for readability)This currently affect unnamed cross reference symbols from revisions.At least ability to determine non-LTCG and LTCG xrefs need to remain separate for X reason.Need to purge global cross reference strings list.With full xreference cache system, we can reduce unnecessary rescan same symbol. Except, we do still have other optimization to do. I believe this pull request partially resolve #87 ticket.
With cross reference's symbols separated into their own library file. It will be easier to maintenance and organizing.
Pros:
Cons:
Hmm, I thought I had mentioned before. You can use "extend oovpa test to verify symbol's reference against revisions" commit for verification of internal test is working for compare revisions' xref vs symbol group's xref difference.