-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update package.json for vite5 / svelte 3 #313
Labels
enhancement
New feature or request
Comments
@benoitf Yes, please feel free to submit a PR! |
@benoitf are you working on it? |
hello, I forgot |
@Cweili Example of another package that had to make similar changes: fedorovvvv/svelte-floating-ui@a1f7bee |
Cweili
pushed a commit
that referenced
this issue
Jan 5, 2024
* Components are now written in TypeScript, avoiding the need to maintain and test separate type definitions. * Migrated docs site to use SvelteKit and Bootstrap 5. * Switched from Prism to Highlight.js for code syntax highlighting. * Enabled Prettier to autoformat code. * Switched from Jest to Vitest for tests. * Separate `gh-pages` branch is now used to deploy docs so autogenerated files don't have to be committed to master branch. * Added contributing instructions file. These changes should make it a lot easier to build and test the project, lowering the barrier for contributions and future maintenance. Closes #313, closes #311
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
hello,
first, I'm happy to use this library.
But recently I faced an issue with
vite-plugin-svelte
andvite5
When this library was made, these components were older :-)
Here is the issue:
sveltejs/vite-plugin-svelte#813
it seems svelte-fa is not following new recommended approach for svelte usage.
Running it now I can see
and here is the recommandation provided in the vite plugin svelte issue
I don't know if you would accept such PR ?
The text was updated successfully, but these errors were encountered: