Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update package.json for vite5 / svelte 3 #313

Closed
benoitf opened this issue Nov 24, 2023 · 4 comments · Fixed by #315
Closed

update package.json for vite5 / svelte 3 #313

benoitf opened this issue Nov 24, 2023 · 4 comments · Fixed by #315
Labels
enhancement New feature or request

Comments

@benoitf
Copy link

benoitf commented Nov 24, 2023

hello,

first, I'm happy to use this library.

But recently I faced an issue with vite-plugin-svelte and vite5
When this library was made, these components were older :-)

Here is the issue:
sveltejs/vite-plugin-svelte#813

it seems svelte-fa is not following new recommended approach for svelte usage.

Running it now I can see

[vite-plugin-svelte] WARNING: The following packages have a svelte field in their package.json but no exports condition for svelte.

[email protected]
Please see https://github.com/sveltejs/vite-plugin-svelte/blob/main/docs/faq.md#missing-exports-condition for details.

and here is the recommandation provided in the vite plugin svelte issue

My recommendation would be to switch to svelte-package , add "type": "module", add an "exports" map , add publint to verify their package.json is ok. And last but not least maybe don't do mixed exports (default and named) from the index file. Thats not great.

I don't know if you would accept such PR ?

@Cweili
Copy link
Owner

Cweili commented Nov 28, 2023

@benoitf Yes, please feel free to submit a PR!

@Cweili Cweili added the enhancement New feature or request label Nov 29, 2023
@notramo
Copy link

notramo commented Dec 16, 2023

@benoitf are you working on it?

@benoitf
Copy link
Author

benoitf commented Dec 16, 2023

hello, I forgot
I'm not working on it right now

@stephenlrandall
Copy link

@Cweili Example of another package that had to make similar changes: fedorovvvv/svelte-floating-ui@a1f7bee

Cweili pushed a commit that referenced this issue Jan 5, 2024
* Components are now written in TypeScript, avoiding the need to maintain and test separate type definitions.
* Migrated docs site to use SvelteKit and Bootstrap 5.
* Switched from Prism to Highlight.js for code syntax highlighting.
* Enabled Prettier to autoformat code.
* Switched from Jest to Vitest for tests.
* Separate `gh-pages` branch is now used to deploy docs so autogenerated files don't have to be committed to master branch.
* Added contributing instructions file.

These changes should make it a lot easier to build and test the project, lowering the barrier for contributions and future maintenance.

Closes #313, closes #311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants